Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2629793003: Revert "Round the scroll offset synced back to main instead of flooring." (Closed)

Created:
3 years, 11 months ago by flackr
Modified:
3 years, 11 months ago
CC:
chromium-reviews, kinuko+watch, jam, darin-cc_chromium.org, blink-reviews, cc-bugs_chromium.org, android-webview-reviews_chromium.org, chrishtr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Round the scroll offset synced back to main instead of flooring." and disable CompositeOpaqueFixedPosition Reverts the commit 75a7e4cb1ec29ded2e52539259233356caa883c8 (https://codereview.chromium.org/2511473003) and additionally disables CompositeOpaquePosition by default as that commit fixed a compositing bug exposed by compositing more fixed position elements (https://crbug.com/663291). Rounding the synced scroll offset introduced a regression which caused scroll position to become unstable when zoomed in on long sites. TBR=weiliangc,boliu BUG=677686, 663291, 661754 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2629793003 Cr-Commit-Position: refs/heads/master@{#443691} Committed: https://chromium.googlesource.com/chromium/src/+/96f33ef6f7c21303a68dc52c3e27a925fb200ce5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -72 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 3 chunks +3 lines, -51 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M cc/trees/property_tree.cc View 1 chunk +10 lines, -8 lines 0 comments Download
M content/child/runtime_features.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/content_features.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
flackr
Rounding the synced scroll position to fix a compositing bug exposed by compositing opaque fixed ...
3 years, 11 months ago (2017-01-13 13:42:25 UTC) #4
Stephen Chennney
LGTM
3 years, 11 months ago (2017-01-13 18:37:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629793003/1
3 years, 11 months ago (2017-01-13 20:47:45 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 22:06:26 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/96f33ef6f7c21303a68dc52c3e27...

Powered by Google App Engine
This is Rietveld 408576698