Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Issue 2629773004: ozone: Select a crtc even when KMS doesn't report any plane for it. (Closed)

Created:
3 years, 11 months ago by Daniele Castagna
Modified:
3 years, 11 months ago
CC:
malaykeshav, chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Select a crtc even when KMS doesn't report any plane for it. crrev.com/2420083003 changed the logic we use to select a crtc. The new code assumes that KMS advertises at least one plane per crtc. This is not true, and it caused not to select any crtc for certain devices. This change removes that assumption. BUG=680798 Review-Url: https://codereview.chromium.org/2629773004 Cr-Commit-Position: refs/heads/master@{#443766} Committed: https://chromium.googlesource.com/chromium/src/+/aa96a2c8835f1681fa482a9b31316d2f3cd2ccf6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/ozone/platform/drm/common/drm_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
Daniele Castagna
3 years, 11 months ago (2017-01-14 01:07:35 UTC) #5
marcheu
lgtm
3 years, 11 months ago (2017-01-14 01:12:04 UTC) #6
Daniele Castagna
3 years, 11 months ago (2017-01-14 01:21:31 UTC) #8
hshi1
lgtm
3 years, 11 months ago (2017-01-14 01:22:15 UTC) #9
malaykeshav
lgtm
3 years, 11 months ago (2017-01-14 01:24:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629773004/1
3 years, 11 months ago (2017-01-14 01:44:38 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-14 01:49:27 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/aa96a2c8835f1681fa482a9b3131...

Powered by Google App Engine
This is Rietveld 408576698