Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2629773002: Always set bad_message_reason when logging bad message dumps (Closed)

Created:
3 years, 11 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 11 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always set bad_message_reason when logging bad message dumps The crash key was accidentally left unset when bad message dumps were moved to the IO thread. This fixes that. BUG=680542 R=creis@chromium.org Review-Url: https://codereview.chromium.org/2629773002 Cr-Commit-Position: refs/heads/master@{#443440} Committed: https://chromium.googlesource.com/chromium/src/+/d29667992640dc24a65202828f64e7517aa5aba0

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M content/browser/bad_message.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Ken Rockot(use gerrit already)
3 years, 11 months ago (2017-01-13 00:33:39 UTC) #4
Charlie Reis
Much appreciated! LGTM.
3 years, 11 months ago (2017-01-13 00:44:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629773002/20001
3 years, 11 months ago (2017-01-13 00:45:44 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 01:37:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d29667992640dc24a65202828f64...

Powered by Google App Engine
This is Rietveld 408576698