Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2629743002: MD Settings: add border between sync data type toggles (Closed)

Created:
3 years, 11 months ago by Dan Beam
Modified:
3 years, 11 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: add border between sync data type toggles R=tommycli@chromium.org BUG=673953 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2629743002 Cr-Commit-Position: refs/heads/master@{#443430} Committed: https://chromium.googlesource.com/chromium/src/+/7de09d362b972881698c15fc80d66fbb03c55adb

Patch Set 1 #

Total comments: 2

Patch Set 2 : asdf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/resources/settings/people_page/sync_page.html View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Dan Beam
3 years, 11 months ago (2017-01-12 23:26:25 UTC) #2
tommycli
lgtm with nit https://codereview.chromium.org/2629743002/diff/1/chrome/browser/resources/settings/people_page/sync_page.html File chrome/browser/resources/settings/people_page/sync_page.html (right): https://codereview.chromium.org/2629743002/diff/1/chrome/browser/resources/settings/people_page/sync_page.html#newcode70 chrome/browser/resources/settings/people_page/sync_page.html:70: <div class="list-frame" id="types"> sync-data-types ?
3 years, 11 months ago (2017-01-12 23:29:47 UTC) #5
Dan Beam
https://codereview.chromium.org/2629743002/diff/1/chrome/browser/resources/settings/people_page/sync_page.html File chrome/browser/resources/settings/people_page/sync_page.html (right): https://codereview.chromium.org/2629743002/diff/1/chrome/browser/resources/settings/people_page/sync_page.html#newcode70 chrome/browser/resources/settings/people_page/sync_page.html:70: <div class="list-frame" id="types"> On 2017/01/12 23:29:47, tommycli wrote: > ...
3 years, 11 months ago (2017-01-12 23:41:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629743002/20001
3 years, 11 months ago (2017-01-12 23:42:21 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 01:22:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7de09d362b972881698c15fc80d6...

Powered by Google App Engine
This is Rietveld 408576698