Fix the layout of the append button on Answers in Suggest.

Fix the layout of the append button on Answers in Suggest.

The existing layout assumes a fixed height for suggestions in the
omnibox suggestion popup. This assumption is violated by Answers in
Suggest rows. The assumption relates to the horizontal layout. There's
no particular reason why a different horizontal layout might not be
chosen independent of the row height, so this change uses a constant
instead, initially set to the non-AiS height of the suggest rows.

Also, fix some terminology in this file, replacing left/right with
leading/trailing.

BUG=680722
Review-Url: https://codereview.chromium.org/2629723002
Cr-Commit-Position: refs/heads/master@{#443556}
Committed: https://chromium.googlesource.com/chromium/src/+/ae261b81e2f534a606db83c6ef4a15f64237f90f

[Justin Donnelly, 2017-01-12 22:39:09]

The CQ bit was checked by jdonnelly@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 22:40:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Donnelly, 2017-01-12 22:40:30]

jdonnelly@chromium.org changed reviewers:
+ rohitrao@chromium.org

[commit-bot: I haz the power, 2017-01-12 22:54:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 22:54:42]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-01-13 00:17:44]

Description was changed from

==========
Fix the layout of the append button on Answers in Suggest.

The existing layout assumes a fixed height for suggestions in the
omnibox suggestion popup. This assumption is violated by Answers in
Suggest rows. The assumption relates to the horizontal layout. There's
no particular reason why a differnt horizontal layout might not be
chosen independent of the row height, so this change uses a constant
instead, initially set to the non-AiS height of the suggest rows.

Also, fix some terminology in this file, replacing left/right with
leading/trailing.

BUG=680722
==========

to

==========
Fix the layout of the append button on Answers in Suggest.

The existing layout assumes a fixed height for suggestions in the
omnibox suggestion popup. This assumption is violated by Answers in
Suggest rows. The assumption relates to the horizontal layout. There's
no particular reason why a different horizontal layout might not be
chosen independent of the row height, so this change uses a constant
instead, initially set to the non-AiS height of the suggest rows.

Also, fix some terminology in this file, replacing left/right with
leading/trailing.

BUG=680722
==========

[rohitrao (ping after 24h), 2017-01-13 00:17:59]

lgtm

[Justin Donnelly, 2017-01-13 14:48:58]

The CQ bit was checked by jdonnelly@chromium.org

[commit-bot: I haz the power, 2017-01-13 14:49:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 14:52:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484318938171410, "parent_rev":
"be3576dd35b1cd9da3e71ad8f00cea203d3fcbd5", "commit_rev":
"ae261b81e2f534a606db83c6ef4a15f64237f90f"}

[commit-bot: I haz the power, 2017-01-13 14:53:14]

Description was changed from

==========
Fix the layout of the append button on Answers in Suggest.

The existing layout assumes a fixed height for suggestions in the
omnibox suggestion popup. This assumption is violated by Answers in
Suggest rows. The assumption relates to the horizontal layout. There's
no particular reason why a different horizontal layout might not be
chosen independent of the row height, so this change uses a constant
instead, initially set to the non-AiS height of the suggest rows.

Also, fix some terminology in this file, replacing left/right with
leading/trailing.

BUG=680722
==========

to

==========
Fix the layout of the append button on Answers in Suggest.

The existing layout assumes a fixed height for suggestions in the
omnibox suggestion popup. This assumption is violated by Answers in
Suggest rows. The assumption relates to the horizontal layout. There's
no particular reason why a different horizontal layout might not be
chosen independent of the row height, so this change uses a constant
instead, initially set to the non-AiS height of the suggest rows.

Also, fix some terminology in this file, replacing left/right with
leading/trailing.

BUG=680722

Review-Url: https://codereview.chromium.org/2629723002
Cr-Commit-Position: refs/heads/master@{#443556}
Committed:
https://chromium.googlesource.com/chromium/src/+/ae261b81e2f534a606db83c6ef4a...
==========

[commit-bot: I haz the power, 2017-01-13 14:53:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae261b81e2f534a606db83c6ef4a...