Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2629703002: Fix test flakiness (Closed)

Created:
3 years, 11 months ago by qinmin
Modified:
3 years, 11 months ago
Reviewers:
gone
CC:
chromium-reviews, asanka
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix test flakiness mStarted is set on UI thread, so we shouldn't check it on other threads. And there is no point to check it at the beginning of the test since it is always false. BUG=680533 Review-Url: https://codereview.chromium.org/2629703002 Cr-Commit-Position: refs/heads/master@{#443507} Committed: https://chromium.googlesource.com/chromium/src/+/860143d6bc67646d446e061de9ad873372965bd2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
qinmin
PTAL
3 years, 11 months ago (2017-01-12 21:42:29 UTC) #2
gone
lgtm
3 years, 11 months ago (2017-01-12 21:43:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629703002/1
3 years, 11 months ago (2017-01-12 21:47:51 UTC) #5
commit-bot: I haz the power
Failed to commit the patch.
3 years, 11 months ago (2017-01-12 22:52:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629703002/1
3 years, 11 months ago (2017-01-13 06:16:32 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 06:20:59 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/860143d6bc67646d446e061de9ad...

Powered by Google App Engine
This is Rietveld 408576698