Add window position offset.

Add window position offset.

Test CL, DO NOT SUBMIT.

BUG=680271

[tonikitoo, 2017-01-13 17:07:13]

tonikitoo@igalia.com changed reviewers:
+ tonikitoo@igalia.com

[tonikitoo, 2017-01-13 17:07:14]

Thanks for taking the time and putting the together, kylechar.

Some feedback:

1) it does "fixes" the problem for chrome/mash/ozone.

2) it actually breaks chrome/mash (non-ozone), that used to work before.
Note that I needed to manually revert https://codereview.chromium.org/2555893002
(SHA  bb77840), for the sake of testing ChromeOS/mash on X11.

So, the problem here seems not mash VS non-mash, but instead ozone VS non-ozone
chromeos builds.

Is that anything ozone and non-ozone codepaths differ that could lead to this
problem?


Also, in the bug [1], you wrote:

"For non-mustash Chrome OS running on Linux, when you resize the PlatformWindow
it changes the display resolution to match the window size. We could do
something like that."

Maybe you mean "non-ozone" rather than "non-mustash"?

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=680271#c9

https://codereview.chromium.org/2629653002/diff/1/services/ui/ws/platform_dis...
File services/ui/ws/platform_display_default.cc (right):

https://codereview.chromium.org/2629653002/diff/1/services/ui/ws/platform_dis...
services/ui/ws/platform_display_default.cc:194:
UpdateEventRootLocation(located_event);
driven-by comment: maybe moving moving this offset-change code to within
::UpdateEventRootLocation, where LocatedEvent::root_location_ gets updated any
ways?

[kylechar, 2017-01-13 17:18:32]

On 2017/01/13 17:07:14, tonikitoo wrote:
> Thanks for taking the time and putting the together, kylechar.
> 
> Some feedback:
> 
> 1) it does "fixes" the problem for chrome/mash/ozone.
> 
> 2) it actually breaks chrome/mash (non-ozone), that used to work before.
> Note that I needed to manually revert
https://codereview.chromium.org/2555893002
> (SHA  bb77840), for the sake of testing ChromeOS/mash on X11.
> 
> So, the problem here seems not mash VS non-mash, but instead ozone VS
non-ozone
> chromeos builds.
> 
> Is that anything ozone and non-ozone codepaths differ that could lead to this
> problem?

There are lots of differences. Definitely the code that converts XEvents into
ui::Events is different although it was supposed to be roughly equivalent. We
aren't supporting X11 CrOS anymore for mustash though. crrev.com/2555893002 was
submitted to make sure no one accidentally ran it :)

> Also, in the bug [1], you wrote:
> 
> "For non-mustash Chrome OS running on Linux, when you resize the
PlatformWindow
> it changes the display resolution to match the window size. We could do
> something like that."
> 
> Maybe you mean "non-ozone" rather than "non-mustash"?

No, I mean non-mustash. When running Chrome for Chrome OS (aka classic ash or
cash as we often call it) on Linux the display management code listens for
PlatformWindow resizes and pretends the display resolution has changed
accordingly.

> [1] https://bugs.chromium.org/p/chromium/issues/detail?id=680271#c9
> 
>
https://codereview.chromium.org/2629653002/diff/1/services/ui/ws/platform_dis...
> File services/ui/ws/platform_display_default.cc (right):
> 
>
https://codereview.chromium.org/2629653002/diff/1/services/ui/ws/platform_dis...
> services/ui/ws/platform_display_default.cc:194:
> UpdateEventRootLocation(located_event);
> driven-by comment: maybe moving moving this offset-change code to within
> ::UpdateEventRootLocation, where LocatedEvent::root_location_ gets updated any
> ways?

I'm not sure this approach is actually workable but yes, moving everything into
the one method would be better.

[kylechar, 2017-01-13 17:19:18]

Description was changed from

==========
Add window position offset.

If the window is resized, we should probably pretend the Chrome OS
display resized. This doesn't happen, so a hack is to add an offset.
Only the height needs to be adjusted since we draw from the bottom.

BUG=680271
==========

to

==========
Add window position offset.

Test CL, DO NOT SUBMIT.

BUG=680271
==========