Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 2555893002: Remove mustash tests from X11 CrOS trybots. (Closed)

Created:
4 years ago by kylechar
Modified:
4 years ago
Reviewers:
James Cook, sky
CC:
chromium-reviews, rjkroege, sadrul, James Cook
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove mustash tests from X11 CrOS trybots. All of the mutash tests that ran on a X11 CrOS trybot now also run on the Ozone CrOS trybot. We have no plans to support a X11 CrOS release and we have Ozone X11 CrOS for development. Remove mustash tests from X11 CrOS trybot and disable mustash when running with X11 CrOS. BUG=none Committed: https://crrev.com/bb77840039a03ce9e18fe5b411d5a310fcec6d78 Cr-Commit-Position: refs/heads/master@{#437377}

Patch Set 1 #

Patch Set 2 : No PlatformWindow for X11 CrOS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -56 lines) Patch
M services/ui/ws/platform_display_default.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 5 chunks +0 lines, -54 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
kylechar
If there are no objections then dropping X11 CrOS support entirely seems beneficial, one less ...
4 years ago (2016-12-07 14:30:28 UTC) #6
sky
LGTM
4 years ago (2016-12-07 16:59:29 UTC) #7
James Cook
lgtm too
4 years ago (2016-12-07 17:34:00 UTC) #9
James Cook
One thought... Did these tests and chrome --mash kinda-sorta work with non-ozone X11 CrOS before ...
4 years ago (2016-12-07 17:37:54 UTC) #10
kylechar
On 2016/12/07 17:37:54, James Cook wrote: > One thought... Did these tests and chrome --mash ...
4 years ago (2016-12-07 19:52:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555893002/20001
4 years ago (2016-12-08 14:15:39 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82283)
4 years ago (2016-12-08 15:32:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555893002/20001
4 years ago (2016-12-08 21:02:46 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 22:47:27 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-08 22:49:45 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bb77840039a03ce9e18fe5b411d5a310fcec6d78
Cr-Commit-Position: refs/heads/master@{#437377}

Powered by Google App Engine
This is Rietveld 408576698