Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 262963002: Revert of Add support for glMapBufferRange. Use glMapBufferRange and glMapBufferSubData. (Closed)

Created:
6 years, 7 months ago by djsollen
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert of Add support for glMapBufferRange. Use glMapBufferRange and glMapBufferSubData. (https://codereview.chromium.org/243413002/) Reason for revert: This is firing an assert on many of the Android debug bots Original issue's description: > Add support for glMapBufferRange. Use glMapBufferRange and glMapBufferSubData. > > BUG=skia:2402 > > Committed: http://code.google.com/p/skia/source/detail?r=14533

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -370 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 2 chunks +0 lines, -2 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/gpu/GrBufferAllocPool.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 5 chunks +3 lines, -26 lines 0 comments Download
M src/gpu/GrDrawTargetCaps.h View 2 chunks +2 lines, -16 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLBufferImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLBufferImpl.cpp View 8 chunks +18 lines, -79 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 5 chunks +7 lines, -16 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 6 chunks +8 lines, -36 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 6 chunks +4 lines, -32 lines 0 comments Download
M src/gpu/gl/GrGLDefines.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 3 chunks +5 lines, -13 lines 0 comments Download
M src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp View 2 chunks +1 line, -13 lines 0 comments Download
M src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M src/gpu/gl/debug/GrBufferObj.h View 2 chunks +2 lines, -10 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 9 chunks +41 lines, -95 lines 0 comments Download
M src/gpu/gl/iOS/GrGLCreateNativeInterface_iOS.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
djsollen
Created Revert of Add support for glMapBufferRange. Use glMapBufferRange and glMapBufferSubData.
6 years, 7 months ago (2014-05-02 17:37:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/262963002/1
6 years, 7 months ago (2014-05-02 17:37:33 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 17:37:34 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-02 17:37:34 UTC) #4
djsollen
6 years, 7 months ago (2014-05-02 17:45:54 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698