Parser: Fix InitializerRewriter.

Parser: Fix InitializerRewriter.

The bug was caused by AstTraversalVisitor refactoring: 
https://codereview.chromium.org/2169833002/

InitializerRewriter::VisitRewritableExpression in parser.cc didn't recurse; so
it fails when a rewritable expression contains another rewritable expression.

See the bug for more details.

BUG=chromium:679727
Review-Url: https://codereview.chromium.org/2629623002
Cr-Commit-Position: refs/heads/master@{#42274}
Committed: https://chromium.googlesource.com/v8/v8/+/aff64e9dfa436f62555325daf788e81f59b810fb

[marja, 2017-01-12 15:11:21]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 15:11:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2017-01-12 15:16:28]

Description was changed from

==========
Parser: Fix InitializerRewriter.

The bug was caused by AstTraversalVisitor refactoring
(InitializerRewriter::VisitRewritableExpression in parser.cc didn't recurse; so
it fails when a rewritable expression contains another rewritable expression).

BUG=chromium:679727
==========

to

==========
Parser: Fix InitializerRewriter.

The bug was caused by AstTraversalVisitor refactoring: 
https://codereview.chromium.org/2169833002/


(InitializerRewriter::VisitRewritableExpression in parser.cc didn't recurse; so
it fails when a rewritable expression contains another rewritable expression).

BUG=chromium:679727
==========

[marja, 2017-01-12 15:31:01]

marja@chromium.org changed reviewers:
+ caitp@igalia.com, nikolaos@chromium.org

[marja, 2017-01-12 15:31:02]

adamk, verwaest: fyi, since you reviewed the CL that broke this

nikolaos, ptal

See the bug for a detailed explanation on what went wrong in the refactoring.

[marja, 2017-01-12 15:31:24]

Description was changed from

==========
Parser: Fix InitializerRewriter.

The bug was caused by AstTraversalVisitor refactoring: 
https://codereview.chromium.org/2169833002/


(InitializerRewriter::VisitRewritableExpression in parser.cc didn't recurse; so
it fails when a rewritable expression contains another rewritable expression).

BUG=chromium:679727
==========

to

==========
Parser: Fix InitializerRewriter.

The bug was caused by AstTraversalVisitor refactoring: 
https://codereview.chromium.org/2169833002/

InitializerRewriter::VisitRewritableExpression in parser.cc didn't recurse; so
it fails when a rewritable expression contains another rewritable expression.
See the bug for more details.

BUG=chromium:679727
==========

[marja, 2017-01-12 15:31:33]

Description was changed from

==========
Parser: Fix InitializerRewriter.

The bug was caused by AstTraversalVisitor refactoring: 
https://codereview.chromium.org/2169833002/

InitializerRewriter::VisitRewritableExpression in parser.cc didn't recurse; so
it fails when a rewritable expression contains another rewritable expression.
See the bug for more details.

BUG=chromium:679727
==========

to

==========
Parser: Fix InitializerRewriter.

The bug was caused by AstTraversalVisitor refactoring: 
https://codereview.chromium.org/2169833002/

InitializerRewriter::VisitRewritableExpression in parser.cc didn't recurse; so
it fails when a rewritable expression contains another rewritable expression.

See the bug for more details.

BUG=chromium:679727
==========

[nickie, 2017-01-12 15:35:00]

On 2017/01/12 15:31:02, marja wrote:
> adamk, verwaest: fyi, since you reviewed the CL that broke this
> 
> nikolaos, ptal
> 
> See the bug for a detailed explanation on what went wrong in the refactoring.

We discussed this offline extensively with Marja and I totally agree.
LGTM.

[marja, 2017-01-12 15:35:41]

The CQ bit was unchecked by marja@chromium.org

[marja, 2017-01-12 15:35:47]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2017-01-12 15:35:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 15:52:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484235347668460, "parent_rev":
"148a903d92040d004a472ef3423211975ec3cb6d", "commit_rev":
"aff64e9dfa436f62555325daf788e81f59b810fb"}

[commit-bot: I haz the power, 2017-01-12 15:52:06]

Description was changed from

==========
Parser: Fix InitializerRewriter.

The bug was caused by AstTraversalVisitor refactoring: 
https://codereview.chromium.org/2169833002/

InitializerRewriter::VisitRewritableExpression in parser.cc didn't recurse; so
it fails when a rewritable expression contains another rewritable expression.

See the bug for more details.

BUG=chromium:679727
==========

to

==========
Parser: Fix InitializerRewriter.

The bug was caused by AstTraversalVisitor refactoring: 
https://codereview.chromium.org/2169833002/

InitializerRewriter::VisitRewritableExpression in parser.cc didn't recurse; so
it fails when a rewritable expression contains another rewritable expression.

See the bug for more details.

BUG=chromium:679727

Review-Url: https://codereview.chromium.org/2629623002
Cr-Commit-Position: refs/heads/master@{#42274}
Committed:
https://chromium.googlesource.com/v8/v8/+/aff64e9dfa436f62555325daf788e81f59b...
==========

[commit-bot: I haz the power, 2017-01-12 15:52:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/aff64e9dfa436f62555325daf788e81f59b...

[adamk, 2017-01-12 18:35:09]

adamk@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2017-01-12 18:35:09]

Thanks for the fix!