Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2629613002: Revert "Verify that FetchEvent::m_request holds same-thread reference." (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
Reviewers:
haraken, nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Verify that FetchEvent::m_request holds same-thread reference." Undo r440475's temporary use of SameThreadCheckedMember<>. R= BUG=655926 Review-Url: https://codereview.chromium.org/2629613002 Cr-Commit-Position: refs/heads/master@{#443257} Committed: https://chromium.googlesource.com/chromium/src/+/5e3d4684cd45c0aa08d541646e035d4e03bec8af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sof
please take a look.
3 years, 11 months ago (2017-01-12 13:38:16 UTC) #4
haraken
LGTM
3 years, 11 months ago (2017-01-12 15:55:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629613002/1
3 years, 11 months ago (2017-01-12 16:23:18 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 16:28:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5e3d4684cd45c0aa08d541646e03...

Powered by Google App Engine
This is Rietveld 408576698