Added constness to the hashmap on Document.

Added constness to the hashmap on Document.

Made the Node key on the hashmap const and made the getStyleReattachData
method const.

BUG=595137
Review-Url: https://codereview.chromium.org/2629603003
Cr-Commit-Position: refs/heads/master@{#443951}
Committed: https://chromium.googlesource.com/chromium/src/+/2b7d25ee19b21a8da3c3c97c6304bba3d3608df0

[Bugs Nash, 2017-01-13 01:07:15]

The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 01:08:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bugs Nash, 2017-01-13 01:10:31]

bugsnash@chromium.org changed reviewers:
+ ktyliu@chromium.org

[ktyliu, 2017-01-13 02:04:05]

lgtm

adding const is good :)

https://codereview.chromium.org/2629603003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/2629603003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Document.cpp:1371:
m_styleReattachDataMap.set(&node, styleReattachData);
not related to your change, but "&node" should better be "node"?
(similarly below)

[Bugs Nash, 2017-01-13 02:07:49]

bugsnash@chromium.org changed reviewers:
+ esprehn@chromium.org

[Bugs Nash, 2017-01-13 02:08:40]

Elliott ptal

https://codereview.chromium.org/2629603003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/2629603003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Document.cpp:1371:
m_styleReattachDataMap.set(&node, styleReattachData);
On 2017/01/13 at 02:04:05, ktyliu wrote:
> not related to your change, but "&node" should better be "node"?
> (similarly below)

the set method is taking a Node* here (or more accurately a Member<Node> which
is a fancy pointer) so I believe &node is necessary

[Bugs Nash, 2017-01-13 03:00:54]

bugsnash@chromium.org changed reviewers:
+ nainar@chromium.org

[commit-bot: I haz the power, 2017-01-13 04:28:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 04:28:38]

Dry run: This issue passed the CQ dry run.

[nainar, 2017-01-13 07:16:24]

lgtm

[esprehn, 2017-01-13 07:43:39]

lgtm

[Bugs Nash, 2017-01-13 08:17:25]

The CQ bit was checked by bugsnash@chromium.org

[commit-bot: I haz the power, 2017-01-13 08:17:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 08:21:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 08:21:16]

Failed to apply patch for third_party/WebKit/Source/core/dom/Document.h:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/Source/core/dom/Document.h:345
  error: third_party/WebKit/Source/core/dom/Document.h: patch does not apply

Patch:       third_party/WebKit/Source/core/dom/Document.h
Index: third_party/WebKit/Source/core/dom/Document.h
diff --git a/third_party/WebKit/Source/core/dom/Document.h
b/third_party/WebKit/Source/core/dom/Document.h
index
47df5cc4ba95ff8578e3cfaab36c464463590075..39489d86bb1bc0e17b05d98a0f2ab8ae0c3d277b
100644
--- a/third_party/WebKit/Source/core/dom/Document.h
+++ b/third_party/WebKit/Source/core/dom/Document.h
@@ -345,8 +345,8 @@ class CORE_EXPORT Document : public ContainerNode,
   Range* caretRangeFromPoint(int x, int y);
   Element* scrollingElement();
 
-  void addStyleReattachData(Node&, StyleReattachData&);
-  StyleReattachData getStyleReattachData(Node&);
+  void addStyleReattachData(const Node&, StyleReattachData&);
+  StyleReattachData getStyleReattachData(const Node&) const;
 
   String readyState() const;
 
@@ -1446,7 +1446,7 @@ class CORE_EXPORT Document : public ContainerNode,
   // This HashMap is used to stash information (ComputedStyle, nextTextSibling)
   // generated in the Style Resolution phase that is required in the
   // Layout Tree construction phase.
-  HeapHashMap<Member<Node>, StyleReattachData> m_styleReattachDataMap;
+  HeapHashMap<Member<const Node>, StyleReattachData> m_styleReattachDataMap;
 
   bool m_wellFormed;

[Bugs Nash, 2017-01-16 20:50:55]

The CQ bit was checked by bugsnash@chromium.org

[Bugs Nash, 2017-01-16 20:50:55]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
esprehn@chromium.org, ktyliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2629603003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-16 20:51:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 22:14:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484599855286720,
"parent_rev": "84f416819a18138cdf94d39f7f0e313fb310a94a", "commit_rev":
"2b7d25ee19b21a8da3c3c97c6304bba3d3608df0"}

[commit-bot: I haz the power, 2017-01-16 22:15:14]

Description was changed from

==========
Added constness to the hashmap on Document.

Made the Node key on the hashmap const and made the getStyleReattachData
method const.

BUG=595137
==========

to

==========
Added constness to the hashmap on Document.

Made the Node key on the hashmap const and made the getStyleReattachData
method const.

BUG=595137

Review-Url: https://codereview.chromium.org/2629603003
Cr-Commit-Position: refs/heads/master@{#443951}
Committed:
https://chromium.googlesource.com/chromium/src/+/2b7d25ee19b21a8da3c3c97c6304...
==========

[commit-bot: I haz the power, 2017-01-16 22:15:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2b7d25ee19b21a8da3c3c97c6304...