third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp - Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp

Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed (Closed)

Patch Set: temp Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.h ('k') | third_party/WebKit/Source/modules/webmidi/MIDIPort.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp

diff --git a/third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp b/third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp

index fe1aa79f330a5389bfdcf5a6d724411ac6ac7e9e..ceb4f7fbd64790a8a62c3ba788556119eeac1642 100644

--- a/third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp

+++ b/third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp

@@ -30,9 +30,8 @@ MIDIAccessInitializer::MIDIAccessInitializer(ScriptState* scriptState,

const MIDIOptions& options)

: ScriptPromiseResolver(scriptState), m_options(options) {}

-void MIDIAccessInitializer::contextDestroyed() {

+void MIDIAccessInitializer::contextDestroyed(ExecutionContext*) {

m_permissionService.reset();

- LifecycleObserver::contextDestroyed();

}

ScriptPromise MIDIAccessInitializer::start() {