Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp

Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed (Closed)
Patch Set: temp Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/webmidi/MIDIAccessInitializer.h" 5 #include "modules/webmidi/MIDIAccessInitializer.h"
6 6
7 #include "bindings/core/v8/ScriptPromise.h" 7 #include "bindings/core/v8/ScriptPromise.h"
8 #include "bindings/core/v8/ScriptPromiseResolver.h" 8 #include "bindings/core/v8/ScriptPromiseResolver.h"
9 #include "core/dom/DOMException.h" 9 #include "core/dom/DOMException.h"
10 #include "core/dom/Document.h" 10 #include "core/dom/Document.h"
(...skipping 12 matching lines...) Expand all
23 namespace blink { 23 namespace blink {
24 24
25 using midi::mojom::PortState; 25 using midi::mojom::PortState;
26 using midi::mojom::Result; 26 using midi::mojom::Result;
27 using mojom::blink::PermissionStatus; 27 using mojom::blink::PermissionStatus;
28 28
29 MIDIAccessInitializer::MIDIAccessInitializer(ScriptState* scriptState, 29 MIDIAccessInitializer::MIDIAccessInitializer(ScriptState* scriptState,
30 const MIDIOptions& options) 30 const MIDIOptions& options)
31 : ScriptPromiseResolver(scriptState), m_options(options) {} 31 : ScriptPromiseResolver(scriptState), m_options(options) {}
32 32
33 void MIDIAccessInitializer::contextDestroyed() { 33 void MIDIAccessInitializer::contextDestroyed(ExecutionContext*) {
34 m_permissionService.reset(); 34 m_permissionService.reset();
35 LifecycleObserver::contextDestroyed();
36 } 35 }
37 36
38 ScriptPromise MIDIAccessInitializer::start() { 37 ScriptPromise MIDIAccessInitializer::start() {
39 ScriptPromise promise = this->promise(); 38 ScriptPromise promise = this->promise();
40 m_accessor = MIDIAccessor::create(this); 39 m_accessor = MIDIAccessor::create(this);
41 40
42 connectToPermissionService(getExecutionContext(), 41 connectToPermissionService(getExecutionContext(),
43 mojo::MakeRequest(&m_permissionService)); 42 mojo::MakeRequest(&m_permissionService));
44 m_permissionService->RequestPermission( 43 m_permissionService->RequestPermission(
45 createMidiPermissionDescriptor(m_options.hasSysex() && m_options.sysex()), 44 createMidiPermissionDescriptor(m_options.hasSysex() && m_options.sysex()),
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 120
122 void MIDIAccessInitializer::onPermissionUpdated(PermissionStatus status) { 121 void MIDIAccessInitializer::onPermissionUpdated(PermissionStatus status) {
123 m_permissionService.reset(); 122 m_permissionService.reset();
124 if (status == PermissionStatus::GRANTED) 123 if (status == PermissionStatus::GRANTED)
125 m_accessor->startSession(); 124 m_accessor->startSession();
126 else 125 else
127 reject(DOMException::create(SecurityError)); 126 reject(DOMException::create(SecurityError));
128 } 127 }
129 128
130 } // namespace blink 129 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698