third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h - Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h

Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed (Closed)

Patch Set: temp Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/presentation/PresentationController.cpp ('k') | third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h

diff --git a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h

index 8863622b8460cbf6ddbb207541474e0297ed3542..bba564b7b0c0a48d287ca71fc3b330a79180792f 100644

--- a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h

+++ b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h

@@ -54,10 +54,11 @@ class MODULES_EXPORT ScreenOrientationControllerImpl final

void registerWithDispatcher() override;

void unregisterWithDispatcher() override;

bool hasLastData() override;

- void pageVisibilityChanged() override;

- // Inherited from ContextLifecycleObserver.

- void contextDestroyed() override;

+ // Inherited from ContextLifecycleObserver and PageVisibilityObserver.

+ void contextDestroyed(ExecutionContext*) override;

+ void contextDestroyed(Page*) override;

+ void pageVisibilityChanged() override;

void notifyDispatcher();