third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp - Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp

Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed (Closed)

Patch Set: temp Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h ('k') | third_party/WebKit/Source/modules/sensor/Sensor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp

diff --git a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp

index ad9c003334a2d5a4b7453f7b6b2b3952795d9a5c..a9d229072ecf70f9cbd64da9f989f52dcbb47e0f 100644

--- a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp

+++ b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp

@@ -209,12 +209,14 @@ bool ScreenOrientationControllerImpl::hasLastData() {

return true;

}

-void ScreenOrientationControllerImpl::contextDestroyed() {

+void ScreenOrientationControllerImpl::contextDestroyed(ExecutionContext*) {

stopUpdating();

m_client = nullptr;

m_activeLock = false;

}

+void ScreenOrientationControllerImpl::contextDestroyed(Page*) {}

void ScreenOrientationControllerImpl::notifyDispatcher() {

if (m_orientation && page()->isPageVisible())

startUpdating();