third_party/WebKit/Source/modules/geolocation/Geolocation.h - Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/geolocation/Geolocation.h

Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed (Closed)

Patch Set: temp Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/geolocation/Geolocation.h

diff --git a/third_party/WebKit/Source/modules/geolocation/Geolocation.h b/third_party/WebKit/Source/modules/geolocation/Geolocation.h

index b4ce6f024d39213488c99a2b62894e3f4bbe8cae..7eb7c86894b6032b8f8b1f2c621a9010ea84ae40 100644

--- a/third_party/WebKit/Source/modules/geolocation/Geolocation.h

+++ b/third_party/WebKit/Source/modules/geolocation/Geolocation.h

@@ -64,8 +64,9 @@ class MODULES_EXPORT Geolocation final

~Geolocation();

DECLARE_VIRTUAL_TRACE();

- // Inherited from ContextLifecycleObserver AND PageVisibilityObserver.

- void contextDestroyed() override;

+ // Inherited from ContextLifecycleObserver and PageVisibilityObserver.

+ void contextDestroyed(ExecutionContext*) override;

+ void contextDestroyed(Page*) override;

Document* document() const;

LocalFrame* frame() const;