Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Unified Diff: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

Issue 2629593004: Disambiguate LifecycleObserver::contextDestroyed (Closed)
Patch Set: temp Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
diff --git a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
index 3f0f768d638b2c020a9333fbb0ab07972c2e3542..8268f24db46a849a1e71572cd2fd6fd644cc08bf 100644
--- a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
+++ b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
@@ -114,7 +114,7 @@ LocalFrame* Geolocation::frame() const {
return document() ? document()->frame() : 0;
}
-void Geolocation::contextDestroyed() {
+void Geolocation::contextDestroyed(ExecutionContext*) {
m_permissionService.reset();
cancelAllRequests();
stopUpdating();
@@ -123,6 +123,8 @@ void Geolocation::contextDestroyed() {
m_lastPosition = nullptr;
}
+void Geolocation::contextDestroyed(Page*) {}
+
void Geolocation::recordOriginTypeAccess() const {
DCHECK(frame());

Powered by Google App Engine
This is Rietveld 408576698