Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2629583003: Remove TaskTraits::with_file_io(). (Closed)

Created:
3 years, 11 months ago by fdoray
Modified:
3 years, 11 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, vmpstr+watch_chromium.org, robliao+watch_chromium.org, jam, gab+watch_chromium.org, darin-cc_chromium.org, fdoray+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M base/task_scheduler/task_traits.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/task_scheduler_util/browser/initialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_process_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/app/web_main_loop.mm View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (12 generated)
fdoray
PTAL
3 years, 11 months ago (2017-01-12 18:02:19 UTC) #4
gab
lgtm
3 years, 11 months ago (2017-01-12 18:52:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629583003/1
3 years, 11 months ago (2017-01-12 19:06:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/340862)
3 years, 11 months ago (2017-01-12 19:18:49 UTC) #11
robliao
lgtm
3 years, 11 months ago (2017-01-12 20:08:23 UTC) #12
fdoray
jam@: Please review changes in content/ eugenebut@: Please review changes in ios/web/
3 years, 11 months ago (2017-01-13 13:06:35 UTC) #14
gab
On 2017/01/13 13:06:35, fdoray wrote: > jam@: Please review changes in content/ > > eugenebut@: ...
3 years, 11 months ago (2017-01-13 13:43:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629583003/1
3 years, 11 months ago (2017-01-13 13:46:54 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/eefdba8c290aa873aba574b2458ae689d65f1397
3 years, 11 months ago (2017-01-13 13:51:06 UTC) #21
Eugene But (OOO till 7-30)
3 years, 11 months ago (2017-01-13 16:29:23 UTC) #22
Message was sent while issue was closed.
ios lgtm

Powered by Google App Engine
This is Rietveld 408576698