Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: chrome/browser/android/webapk/webapk_info.h

Issue 2629573004: Add a chrome://webapks page. (Closed)
Patch Set: Add a chrome://webapks page. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_info.h
diff --git a/chrome/browser/android/webapk/webapk_info.h b/chrome/browser/android/webapk/webapk_info.h
new file mode 100644
index 0000000000000000000000000000000000000000..6fa3f5182dd6a8a5ac83314aef1ce4c9c326ded7
--- /dev/null
+++ b/chrome/browser/android/webapk/webapk_info.h
@@ -0,0 +1,39 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_INFO_H_
+#define CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_INFO_H_
+
+#include <string>
+
+#include "base/macros.h"
+
+// Structure with information about a WebAPK.
dominickn 2017/01/24 23:15:20 Nit: add a comment like: "This class is passed ar
gonzalon 2017/01/24 23:37:56 Done.
+struct WebApkInfo {
+ WebApkInfo(const std::string&& short_name,
dominickn 2017/01/24 23:15:20 Remove the const from the two string arguments. Th
gonzalon 2017/01/24 23:37:56 Makes sense, removed!
+ const std::string&& package_name,
+ int shell_apk_version,
+ int version_code);
+ ~WebApkInfo();
+
+ WebApkInfo& operator=(WebApkInfo&& other) = default;
+ WebApkInfo(WebApkInfo&& other) = default;
+
+ // Short name of the WebAPK.
+ std::string short_name;
+
+ // Package name of the WebAPK.
+ std::string package_name;
+
+ // Shell APK version of the WebAPK.
+ int shell_apk_version;
+
+ // Version code of the WebAPK.
+ int version_code;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(WebApkInfo);
+};
+
+#endif // CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_INFO_H_

Powered by Google App Engine
This is Rietveld 408576698