Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: chrome/browser/android/webapk/webapk_info.h

Issue 2629573004: Add a chrome://webapks page. (Closed)
Patch Set: Add a chrome://webapks page. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_INFO_H_
6 #define CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_INFO_H_
7
8 #include <string>
9
10 #include "base/macros.h"
11
12 // Structure with information about a WebAPK.
dominickn 2017/01/24 23:15:20 Nit: add a comment like: "This class is passed ar
gonzalon 2017/01/24 23:37:56 Done.
13 struct WebApkInfo {
14 WebApkInfo(const std::string&& short_name,
dominickn 2017/01/24 23:15:20 Remove the const from the two string arguments. Th
gonzalon 2017/01/24 23:37:56 Makes sense, removed!
15 const std::string&& package_name,
16 int shell_apk_version,
17 int version_code);
18 ~WebApkInfo();
19
20 WebApkInfo& operator=(WebApkInfo&& other) = default;
21 WebApkInfo(WebApkInfo&& other) = default;
22
23 // Short name of the WebAPK.
24 std::string short_name;
25
26 // Package name of the WebAPK.
27 std::string package_name;
28
29 // Shell APK version of the WebAPK.
30 int shell_apk_version;
31
32 // Version code of the WebAPK.
33 int version_code;
34
35 private:
36 DISALLOW_COPY_AND_ASSIGN(WebApkInfo);
37 };
38
39 #endif // CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_INFO_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698