Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Unified Diff: chrome/browser/android/webapk/webapk_info.h

Issue 2629573004: Add a chrome://webapks page. (Closed)
Patch Set: Makes the listWebApks method receive a callback on the Java side Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_info.h
diff --git a/chrome/browser/android/webapk/webapk_info.h b/chrome/browser/android/webapk/webapk_info.h
new file mode 100644
index 0000000000000000000000000000000000000000..c224713fb2b2cb002c1a0c1048a93384afe614de
--- /dev/null
+++ b/chrome/browser/android/webapk/webapk_info.h
@@ -0,0 +1,32 @@
+// Copyright (c) 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_INFO_H_
+#define CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_INFO_H_
+
+#include <string>
+
+// Structure with information about a WebAPK.
+struct WebApkInfo {
+ WebApkInfo(std::string short_name,
pkotwicz 2017/01/18 02:08:21 Nit: These should be const references (const std::
pkotwicz 2017/01/19 19:37:16 ^^^ I think that you missed this comment
gonzalon 2017/01/19 23:50:15 Done.
+ std::string package_name,
+ int shell_apk_version,
+ int version_code);
+ WebApkInfo(const WebApkInfo& other);
pkotwicz 2017/01/18 02:08:21 You can remove the copy constructor. The compiler
pkotwicz 2017/01/19 19:37:16 ^^^ I think that you missed this comment
gonzalon 2017/01/19 23:50:15 Done.
+ ~WebApkInfo();
+
+ // Short name of the WebAPK.
+ std::string short_name;
+
+ // Package name of the WebAPK.
+ std::string package_name;
+
+ // Shell APK version of the WebAPK.
+ int shell_apk_version;
+
+ // Version code of the WebAPK.
+ int version_code;
+};
+
+#endif // CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_INFO_H_

Powered by Google App Engine
This is Rietveld 408576698