Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: chrome/browser/android/webapk/webapk_info.h

Issue 2629573004: Add a chrome://webapks page. (Closed)
Patch Set: Makes the listWebApks method receive a callback on the Java side Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_INFO_H_
6 #define CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_INFO_H_
7
8 #include <string>
9
10 // Structure with information about a WebAPK.
11 struct WebApkInfo {
12 WebApkInfo(std::string short_name,
pkotwicz 2017/01/18 02:08:21 Nit: These should be const references (const std::
pkotwicz 2017/01/19 19:37:16 ^^^ I think that you missed this comment
gonzalon 2017/01/19 23:50:15 Done.
13 std::string package_name,
14 int shell_apk_version,
15 int version_code);
16 WebApkInfo(const WebApkInfo& other);
pkotwicz 2017/01/18 02:08:21 You can remove the copy constructor. The compiler
pkotwicz 2017/01/19 19:37:16 ^^^ I think that you missed this comment
gonzalon 2017/01/19 23:50:15 Done.
17 ~WebApkInfo();
18
19 // Short name of the WebAPK.
20 std::string short_name;
21
22 // Package name of the WebAPK.
23 std::string package_name;
24
25 // Shell APK version of the WebAPK.
26 int shell_apk_version;
27
28 // Version code of the WebAPK.
29 int version_code;
30 };
31
32 #endif // CHROME_BROWSER_ANDROID_WEBAPK_WEBAPK_INFO_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698