Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4073)

Unified Diff: chrome/browser/android/shortcut_helper.h

Issue 2629573004: Add a chrome://webapks page. (Closed)
Patch Set: Makes the listWebApks method receive a callback on the Java side Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/shortcut_helper.h
diff --git a/chrome/browser/android/shortcut_helper.h b/chrome/browser/android/shortcut_helper.h
index 1c69e53edf194b1d8c92f901ecc7d9d981bdde72..c00d90ed92895711f837a9d0a6759693e59614bb 100644
--- a/chrome/browser/android/shortcut_helper.h
+++ b/chrome/browser/android/shortcut_helper.h
@@ -5,11 +5,15 @@
#ifndef CHROME_BROWSER_ANDROID_SHORTCUT_HELPER_H_
#define CHROME_BROWSER_ANDROID_SHORTCUT_HELPER_H_
+#include <string>
pkotwicz 2017/01/18 02:08:21 Nit: This include is unnecessary
gonzalon 2017/01/18 15:29:32 I think that's because it's being indirectly inclu
pkotwicz 2017/01/19 19:37:16 Yes, you are right. I does use std::string so it s
+#include <vector>
+
#include "base/android/jni_android.h"
#include "base/android/jni_weak_ref.h"
#include "base/callback_forward.h"
#include "base/macros.h"
#include "chrome/browser/android/shortcut_info.h"
+#include "chrome/browser/android/webapk/webapk_info.h"
#include "chrome/browser/android/webapk/webapk_installer.h"
#include "third_party/skia/include/core/SkBitmap.h"
@@ -114,6 +118,11 @@ class ShortcutHelper {
// when the Web Manifest does not specify a scope URL.
static GURL GetScopeFromURL(const GURL& url);
+ // Fetches information on all the WebAPKs installed on the device and returns
+ // the info to the |callback|.
+ static void ListWebApks(JNIEnv* env,
+ const base::Callback<void(std::vector<WebApkInfo*>)>& callback);
pkotwicz 2017/01/18 02:08:21 You should typedef to make your life easier typed
gonzalon 2017/01/18 15:29:32 Done.
+
private:
ShortcutHelper() = delete;
~ShortcutHelper() = delete;

Powered by Google App Engine
This is Rietveld 408576698