chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java - Issue 2629573004: Add a chrome://webapks page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java

Issue 2629573004: Add a chrome://webapks page. (Closed)

Patch Set: Makes the listWebApks method receive a callback on the Java side Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInfo.java ('k') | chrome/browser/BUILD.gn » ('j') | chrome/browser/android/shortcut_helper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java

diff --git a/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java b/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java

index 377494bdae5659ecf521421ede980fe4317abced..e0c818943cb4f1e84959f59b964d1c5f1fa5fb19 100644

--- a/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java

+++ b/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java

@@ -83,7 +83,7 @@ public class WebApkValidator {

* @param webappPackageName The package name to check

* @return true iff the WebAPK is installed and passes security checks

- private static boolean isValidWebApk(Context context, String webappPackageName) {

+ public static boolean isValidWebApk(Context context, String webappPackageName) {

if (sExpectedSignature == null) {

Log.wtf(TAG, "WebApk validation failure - expected signature not set."

+ "missing call to WebApkValidator.initWithBrowserHostSignature");