Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2629543011: [Android Omnibox] Fixing Emphasizer missing ConnectionSecurityLevel entry in switch (Closed)

Created:
3 years, 11 months ago by fgorski
Modified:
3 years, 11 months ago
Reviewers:
Ted C
CC:
chromium-reviews, jdonnelly+watch_chromium.org, agrieve+watch_chromium.org, estark
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android Omnibox] Fixing Emphasizer missing ConnectionSecurityLevel entry in switch Adding a case statement for HTTP_SHOW_WARNING with a fall-through same as for NONE per usage in LocationBarLayout.java BUG=681115 R=tedchoc@chromium.org Review-Url: https://codereview.chromium.org/2629543011 Cr-Commit-Position: refs/heads/master@{#443733} Committed: https://chromium.googlesource.com/chromium/src/+/91942aefbedd1909d0ab28a87bda8603ca99b87c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
fgorski
Ted, can you take a look and let me know if we need security team ...
3 years, 11 months ago (2017-01-13 19:25:19 UTC) #1
Ted C
On 2017/01/13 19:25:19, fgorski wrote: > Ted, can you take a look and let me ...
3 years, 11 months ago (2017-01-13 23:39:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629543011/1
3 years, 11 months ago (2017-01-13 23:55:48 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-14 00:02:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/91942aefbedd1909d0ab28a87bda...

Powered by Google App Engine
This is Rietveld 408576698