Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 2629543010: Add descriptive comment to top of .pyl files (Closed)

Created:
3 years, 11 months ago by agable
Modified:
3 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add descriptive comment to top of .pyl files This will make it easier for developers to use .pyl files before we switch to something else. Review-Url: https://codereview.chromium.org/2629543010 Cr-Commit-Position: refs/heads/master@{#443683} Committed: https://chromium.googlesource.com/chromium/src/+/643c475ca25c4d5191516af0fb7ac3b87177a89c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/determinism/deterministic_build_whitelist.pyl View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/gritsettings/translation_expectations.pyl View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Dirk Pranke
lgtm.
3 years, 11 months ago (2017-01-13 19:16:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629543010/1
3 years, 11 months ago (2017-01-13 20:09:11 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 21:46:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/643c475ca25c4d5191516af0fb7a...

Powered by Google App Engine
This is Rietveld 408576698