Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2629543005: Test FFT scaling for all orders (Closed)

Created:
3 years, 11 months ago by Raymond Toy
Modified:
3 years, 11 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test FFT scaling for all orders Previously we only tested FFTs up to size 2048, but the AnalyserNode supports up to 32768. Test all sizes. BUG=676722 TEST=realtimeanalyser-fft-scaling.html Review-Url: https://codereview.chromium.org/2629543005 Cr-Commit-Position: refs/heads/master@{#443461} Committed: https://chromium.googlesource.com/chromium/src/+/67926a91215c713e851b4fa83bf64e50907ef53e

Patch Set 1 #

Total comments: 2

Patch Set 2 : Wrap line better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html View 1 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Raymond Toy
PTAL
3 years, 11 months ago (2017-01-12 22:12:38 UTC) #2
hongchan
lgtm with nit https://codereview.chromium.org/2629543005/diff/1/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html File third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html (right): https://codereview.chromium.org/2629543005/diff/1/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html#newcode37 third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html:37: let peakThreshold = [-14.43, -13.56, -13.56, ...
3 years, 11 months ago (2017-01-12 23:26:29 UTC) #3
Raymond Toy
https://codereview.chromium.org/2629543005/diff/1/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html File third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html (right): https://codereview.chromium.org/2629543005/diff/1/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html#newcode37 third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html:37: let peakThreshold = [-14.43, -13.56, -13.56, -13.56, -13.56, -13.56, ...
3 years, 11 months ago (2017-01-12 23:33:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629543005/20001
3 years, 11 months ago (2017-01-12 23:34:56 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 02:10:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/67926a91215c713e851b4fa83bf6...

Powered by Google App Engine
This is Rietveld 408576698