Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2629523009: IME for Mus: Remove OnTextInputModeChanged() from IME's mojo API. (Closed)

Created:
3 years, 11 months ago by Hadi
Modified:
3 years, 11 months ago
Reviewers:
Tom Sepez, sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IME for Mus: Remove OnTextInputModeChanged() from IME's mojo API. We don't have an equivalent method in ui::InputMethod or its subclasses, so this method cannot be used in a meaningful way. BUG=672587 Review-Url: https://codereview.chromium.org/2629523009 Cr-Commit-Position: refs/heads/master@{#443700} Committed: https://chromium.googlesource.com/chromium/src/+/318867a70265ecb47c6dcbddacc153eaf34a99f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M chrome/browser/ui/views/ime_driver/input_method_bridge_chromeos.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ime_driver/input_method_bridge_chromeos.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/ime_driver/simple_input_method.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/ime_driver/simple_input_method.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M services/ui/ime/test_ime_driver/test_ime_driver.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/public/interfaces/ime/ime.mojom View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
Hadi
sky@ please take a look. tsepez@ please review ime.mojom. Thanks.
3 years, 11 months ago (2017-01-13 16:24:27 UTC) #4
Tom Sepez
RS LGTM on deleting code.
3 years, 11 months ago (2017-01-13 17:17:05 UTC) #7
sky
LGTM
3 years, 11 months ago (2017-01-13 20:19:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629523009/1
3 years, 11 months ago (2017-01-13 20:40:36 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 22:28:50 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/318867a70265ecb47c6dcbddacc1...

Powered by Google App Engine
This is Rietveld 408576698