chromeos: changes DisconnectedAppHandler to be associated with a single window

chromeos: changes DisconnectedAppHandler to be associated with a single window

The previous code had a bug that it would never start observing newly
added windows (Changing is sent for old parent, and Changed for new
parent, so DisconnectedAppHandler really need to override both
Changing and Changed). In fixing that I figured it was easier to
reason about if it's associated with a single top level window.

This bug was causing the shelf to never remove items when the window closed.

BUG=none
TEST=none
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2629523006
Cr-Commit-Position: refs/heads/master@{#443486}
Committed: https://chromium.googlesource.com/chromium/src/+/02b9d1440e385a6fd768cbff8d8cf8f2443fceef

[sky, 2017-01-12 21:27:02]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 21:28:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 22:20:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 22:20:26]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-01-12 23:26:54]

lgtm

https://codereview.chromium.org/2629523006/diff/20001/ash/mus/disconnected_ap...
File ash/mus/disconnected_app_handler.cc (right):

https://codereview.chromium.org/2629523006/diff/20001/ash/mus/disconnected_ap...
ash/mus/disconnected_app_handler.cc:16:
DEFINE_OWNED_WINDOW_PROPERTY_KEY(DisconnectedAppHandler,
This ensures the window handler is destroyed with the window itself, right?

[sky, 2017-01-13 03:01:57]

https://codereview.chromium.org/2629523006/diff/20001/ash/mus/disconnected_ap...
File ash/mus/disconnected_app_handler.cc (right):

https://codereview.chromium.org/2629523006/diff/20001/ash/mus/disconnected_ap...
ash/mus/disconnected_app_handler.cc:16:
DEFINE_OWNED_WINDOW_PROPERTY_KEY(DisconnectedAppHandler,
On 2017/01/12 23:26:54, sadrul wrote:
> This ensures the window handler is destroyed with the window itself, right?

You got it.

[sky, 2017-01-13 03:04:35]

The CQ bit was checked by sky@chromium.org

[sky, 2017-01-13 03:04:35]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2629523006/#ps40001
(title: "merge")

[commit-bot: I haz the power, 2017-01-13 03:05:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 04:16:26]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484276675406800,
"parent_rev": "b7f90cae827044cfb2280c8382d993848ef33340", "commit_rev":
"02b9d1440e385a6fd768cbff8d8cf8f2443fceef"}

[commit-bot: I haz the power, 2017-01-13 04:17:46]

Description was changed from

==========
chromeos: changes DisconnectedAppHandler to be associated with a single window

The previous code had a bug that it would never start observing newly
added windows (Changing is sent for old parent, and Changed for new
parent, so DisconnectedAppHandler really need to override both
Changing and Changed). In fixing that I figured it was easier to
reason about if it's associated with a single top level window.

This bug was causing the shelf to never remove items when the window closed.

BUG=none
TEST=none
R=sadrul@chromium.org
==========

to

==========
chromeos: changes DisconnectedAppHandler to be associated with a single window

The previous code had a bug that it would never start observing newly
added windows (Changing is sent for old parent, and Changed for new
parent, so DisconnectedAppHandler really need to override both
Changing and Changed). In fixing that I figured it was easier to
reason about if it's associated with a single top level window.

This bug was causing the shelf to never remove items when the window closed.

BUG=none
TEST=none
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2629523006
Cr-Commit-Position: refs/heads/master@{#443486}
Committed:
https://chromium.googlesource.com/chromium/src/+/02b9d1440e385a6fd768cbff8d8c...
==========

[commit-bot: I haz the power, 2017-01-13 04:17:47]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/02b9d1440e385a6fd768cbff8d8c...