Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2629523005: Revert of Enable viewing render tests results on buildbot on Android FYI bot. (Closed)

Created:
3 years, 11 months ago by mikecase (-- gone --)
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable viewing render tests results on buildbot on Android FYI bot. (patchset #1 id:1 of https://codereview.chromium.org/2625673003/ ) Reason for revert: Reverting since the FYI bot seems to be having trouble running chrome_public_test_apk (seems like device or adb issue). Enabled this on another bot (M tester on chromium.android). Original issue's description: > Enable viewing render tests results on buildbot on Android FYI bot. > > Adding example test with render tests to FYI bot. If everything > works as intended, will enable this on all bots. Will also switch > implementation from needing to be configured by manually setting > render_results_dir to detecting the render_results_dir automatically. TBR=dpranke@chromium.org,mikecase@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2629523005 Cr-Commit-Position: refs/heads/master@{#443372} Committed: https://chromium.googlesource.com/chromium/src/+/946dc8c2a4c7273c0602c80c89468798007f03e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mikecase (-- gone --)
Created Revert of Enable viewing render tests results on buildbot on Android FYI bot.
3 years, 11 months ago (2017-01-12 20:33:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629523005/1
3 years, 11 months ago (2017-01-12 20:34:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/946dc8c2a4c7273c0602c80c89468798007f03e9
3 years, 11 months ago (2017-01-12 21:40:07 UTC) #6
Dirk Pranke
3 years, 11 months ago (2017-01-12 22:14:42 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698