Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2629523003: Update Search Engines settings UI for new search geolocation system. (Closed)

Created:
3 years, 11 months ago by benwells
Modified:
3 years, 11 months ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, raymes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Search Engines settings UI for new search geolocation system. The new search geolocation system slightly changes the way geolocation permission work. This change updates the search engines UI to work with the new system. BUG=674398 Review-Url: https://codereview.chromium.org/2629523003 Cr-Commit-Position: refs/heads/master@{#443448} Committed: https://chromium.googlesource.com/chromium/src/+/8be4e3a24c695eca7635d9488821b6e3efdcb2f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java View 2 chunks +11 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
benwells
3 years, 11 months ago (2017-01-12 06:23:32 UTC) #6
benwells
+cc raymes
3 years, 11 months ago (2017-01-12 07:23:12 UTC) #7
gone
lgtm
3 years, 11 months ago (2017-01-12 18:06:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629523003/1
3 years, 11 months ago (2017-01-12 23:30:55 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 01:47:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8be4e3a24c695eca7635d9488821...

Powered by Google App Engine
This is Rietveld 408576698