Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 2629503002: DevTools: Replace Timeline "New" button with Close (Closed)

Created:
3 years, 11 months ago by alph
Modified:
3 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Replace Timeline "New" button with Close Review-Url: https://codereview.chromium.org/2629503002 Cr-Commit-Position: refs/heads/master@{#443315} Committed: https://chromium.googlesource.com/chromium/src/+/83deda6ccb8bee75dad25fda599500efc67110ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
alph
3 years, 11 months ago (2017-01-11 22:30:10 UTC) #2
pfeldman
lgtm
3 years, 11 months ago (2017-01-11 23:09:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629503002/1
3 years, 11 months ago (2017-01-12 07:13:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/367528)
3 years, 11 months ago (2017-01-12 08:58:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629503002/1
3 years, 11 months ago (2017-01-12 17:04:57 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 19:10:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/83deda6ccb8bee75dad25fda5995...

Powered by Google App Engine
This is Rietveld 408576698