Introduce DOMWindowClient

Introduce DOMWindowClient

The lifetime of ExecutionContext and DOMWindow is a bit different.
In common case, they get detached at the same timing but in a case where
a frame navigates from an initial empty document to another same-origin document,
the ExecutionContext gets detached but the DOMWindow is reused.
Due to the (subtle) difference, we need DOMWindowClient in addition to ContextClient.

ContextClient is a client for objects that want to observe ExecutionContext.
DOMWindowClient is a client for objects that want to observe DOMWindow.

This CL uses DOMWindowClient for Navigator.

BUG=610176
Review-Url: https://codereview.chromium.org/2629493004
Cr-Commit-Position: refs/heads/master@{#443216}
Committed: https://chromium.googlesource.com/chromium/src/+/a82bb82ae350134c763a8e995738fec5d4e2a061

[haraken, 2017-01-12 09:15:46]

Description was changed from

==========
Introduce DOMWindowClient

The lifetime of ExecutionContext and DOMWindow is a bit different.
In common case, they get detached at the same timing but in a case where
a frame navigates from an initial empty document to another same-origin
document,
the ExecutionContext gets detached but the DOMWindow is reused.
Due to the (subtle) different, we need DOMWindowClient in addition to
ContextClient.

ContextClient is a client for objects that want to observe ExecutionContext.
DOMWindowClient is a client for objects that want to observe DOMWindow.

This CL uses DOMWindowClient for Navigator.

BUG=610176
==========

to

==========
Introduce DOMWindowClient

The lifetime of ExecutionContext and DOMWindow is a bit different.
In common case, they get detached at the same timing but in a case where
a frame navigates from an initial empty document to another same-origin
document,
the ExecutionContext gets detached but the DOMWindow is reused.
Due to the (subtle) difference, we need DOMWindowClient in addition to
ContextClient.

ContextClient is a client for objects that want to observe ExecutionContext.
DOMWindowClient is a client for objects that want to observe DOMWindow.

This CL uses DOMWindowClient for Navigator.

BUG=610176
==========

[haraken, 2017-01-12 09:16:19]

haraken@chromium.org changed reviewers:
+ dcheng@chromium.org

[haraken, 2017-01-12 09:16:20]

PTAL

[dcheng, 2017-01-12 09:36:34]

Just one question: do we expect all DOMWindowProperty subclasses to be
DOMWindowClients eventually? From what I can tell, it basically does the same
thing, but doesn't require DOMWindow to call back all the objects to notify on
detach. Is that an accurate summary?

[haraken, 2017-01-12 11:04:24]

On 2017/01/12 09:36:34, dcheng wrote:
> Just one question: do we expect all DOMWindowProperty subclasses to be
> DOMWindowClients eventually? From what I can tell, it basically does the same
> thing, but doesn't require DOMWindow to call back all the objects to notify on
> detach. Is that an accurate summary?

Right. However:

- Previously DOMWindowProperty and ContextLifecycleObserver were randomly used.
So we should not simply replace all DOMWindowProperties with DOMWindowClients.
Some should be replaced with ContextLifecycleObservers/ContextClients.

- I have already replaced all DOMWindowProperties (but Navigator) with
ContextLifecycleObservers/ContextClients. This was wrong. I need to revert some
of them back to DOMWindowClients. Specifically I'll use DOMWindowClients only
for objects that are held by LocalDOMWindow.

[dcheng, 2017-01-12 11:24:42]

LGTM

[haraken, 2017-01-12 11:25:55]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2017-01-12 11:26:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 12:54:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484220355767800, "parent_rev":
"184a5d740d8a272e114007a7822d4b5640ace354", "commit_rev":
"a82bb82ae350134c763a8e995738fec5d4e2a061"}

[commit-bot: I haz the power, 2017-01-12 12:55:17]

Description was changed from

==========
Introduce DOMWindowClient

The lifetime of ExecutionContext and DOMWindow is a bit different.
In common case, they get detached at the same timing but in a case where
a frame navigates from an initial empty document to another same-origin
document,
the ExecutionContext gets detached but the DOMWindow is reused.
Due to the (subtle) difference, we need DOMWindowClient in addition to
ContextClient.

ContextClient is a client for objects that want to observe ExecutionContext.
DOMWindowClient is a client for objects that want to observe DOMWindow.

This CL uses DOMWindowClient for Navigator.

BUG=610176
==========

to

==========
Introduce DOMWindowClient

The lifetime of ExecutionContext and DOMWindow is a bit different.
In common case, they get detached at the same timing but in a case where
a frame navigates from an initial empty document to another same-origin
document,
the ExecutionContext gets detached but the DOMWindow is reused.
Due to the (subtle) difference, we need DOMWindowClient in addition to
ContextClient.

ContextClient is a client for objects that want to observe ExecutionContext.
DOMWindowClient is a client for objects that want to observe DOMWindow.

This CL uses DOMWindowClient for Navigator.

BUG=610176

Review-Url: https://codereview.chromium.org/2629493004
Cr-Commit-Position: refs/heads/master@{#443216}
Committed:
https://chromium.googlesource.com/chromium/src/+/a82bb82ae350134c763a8e995738...
==========

[commit-bot: I haz the power, 2017-01-12 12:55:18]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a82bb82ae350134c763a8e995738...