Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 2629483002: MD Settings: Fix issue of long names breaking layout bounds in People section (Closed)

Created:
3 years, 11 months ago by scottchen
Modified:
3 years, 11 months ago
Reviewers:
tommycli, Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix issue of long names breaking layout bounds in People section BUG=666666 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2629483002 Cr-Commit-Position: refs/heads/master@{#443280} Committed: https://chromium.googlesource.com/chromium/src/+/5e234b7e88e8a8f0c48de5713460fe600d510e72

Patch Set 1 #

Total comments: 1

Patch Set 2 : 80 col #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/resources/settings/people_page/people_page.html View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
scottchen
3 years, 11 months ago (2017-01-11 21:56:41 UTC) #3
scottchen
On 2017/01/11 21:56:41, scottchen wrote: http://imgur.com/a/kmFic
3 years, 11 months ago (2017-01-11 21:56:48 UTC) #4
Dan Beam
lgtm https://codereview.chromium.org/2629483002/diff/1/chrome/browser/resources/settings/people_page/people_page.html File chrome/browser/resources/settings/people_page/people_page.html (right): https://codereview.chromium.org/2629483002/diff/1/chrome/browser/resources/settings/people_page/people_page.html#newcode114 chrome/browser/resources/settings/people_page/people_page.html:114: <div class="middle two-line text-elide" on-tap="onPictureTap_" actionable> 80 col ...
3 years, 11 months ago (2017-01-11 21:59:01 UTC) #6
tommycli
lgtm
3 years, 11 months ago (2017-01-11 22:33:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629483002/20001
3 years, 11 months ago (2017-01-12 17:34:44 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 17:42:04 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5e234b7e88e8a8f0c48de5713460...

Powered by Google App Engine
This is Rietveld 408576698