Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2629403003: [chromedriver] Use NodeType enum for consistency. (Closed)

Created:
3 years, 11 months ago by samuong
Modified:
3 years, 11 months ago
Reviewers:
stgao
CC:
chromium-reviews, samuong+watch_chromium.org, PhistucK
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Use NodeType enum for consistency. BUG=chromedriver:1388 Review-Url: https://codereview.chromium.org/2629403003 Cr-Commit-Position: refs/heads/master@{#443628} Committed: https://chromium.googlesource.com/chromium/src/+/646a2f792c2d73c63d1df79cb698299e1697c447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/chromedriver/js/call_function.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
samuong
3 years, 11 months ago (2017-01-13 18:26:10 UTC) #2
stgao
lgtm
3 years, 11 months ago (2017-01-13 18:40:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629403003/1
3 years, 11 months ago (2017-01-13 18:41:44 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 18:55:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/646a2f792c2d73c63d1df79cb698...

Powered by Google App Engine
This is Rietveld 408576698