Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: third_party/WebKit/Source/core/frame/Location.h

Issue 2629333002: Remove DOMWindowProperty (Closed)
Patch Set: temp Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/Location.h
diff --git a/third_party/WebKit/Source/core/frame/Location.h b/third_party/WebKit/Source/core/frame/Location.h
index bcf777c640cd489efaeb54a0d1181fa964471800..2618f7902d3610eb1c71ca63c432991a7089bb46 100644
--- a/third_party/WebKit/Source/core/frame/Location.h
+++ b/third_party/WebKit/Source/core/frame/Location.h
@@ -33,7 +33,6 @@
#include "bindings/core/v8/ScriptWrappable.h"
#include "core/CoreExport.h"
#include "core/dom/DOMStringList.h"
-#include "core/frame/DOMWindowProperty.h"
#include "wtf/text/WTFString.h"
namespace blink {
@@ -44,11 +43,9 @@ class Frame;
class KURL;
// This class corresponds to the JS Location API, which is the only DOM API
-// besides Window that is operable in a RemoteFrame. Rather than making
-// DOMWindowProperty support RemoteFrames and generating a lot code churn,
-// Location is implemented as a one-off with some custom lifetime management
-// code. Namely, it needs a manual call to reset() from DOMWindow::reset() to
-// ensure it doesn't retain a stale Frame pointer.
+// besides Window that is operable in a RemoteFrame. Location needs to be
+// manually updated in DOMWindow::reset() to ensure it doesn't retain a stale
+// Frame pointer.
class CORE_EXPORT Location final : public GarbageCollected<Location>,
public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();

Powered by Google App Engine
This is Rietveld 408576698