Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Issue 2629333002: Remove DOMWindowProperty (Closed)
Patch Set: temp Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
index 9a9bab134d6487382fc3b5cb897031117dd4844e..62548b8aa75bf41591ef73bae69a0cade671c2cb 100644
--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
@@ -53,7 +53,6 @@
#include "core/fetch/ResourceFetcher.h"
#include "core/frame/BarProp.h"
#include "core/frame/DOMVisualViewport.h"
-#include "core/frame/DOMWindowProperty.h"
#include "core/frame/EventHandlerRegistry.h"
#include "core/frame/FrameConsole.h"
#include "core/frame/FrameView.h"
@@ -479,23 +478,11 @@ MediaQueryList* LocalDOMWindow::matchMedia(const String& media) {
}
void LocalDOMWindow::frameDestroyed() {
- for (const auto& domWindowProperty : m_properties)
- domWindowProperty->frameDestroyed();
-
resetLocation();
- m_properties.clear();
removeAllEventListeners();
disconnectFromFrame();
}
-void LocalDOMWindow::registerProperty(DOMWindowProperty* property) {
- m_properties.add(property);
-}
-
-void LocalDOMWindow::unregisterProperty(DOMWindowProperty* property) {
- m_properties.remove(property);
-}
-
void LocalDOMWindow::registerEventListenerObserver(
EventListenerObserver* eventListenerObserver) {
m_eventListenerObservers.add(eventListenerObserver);
@@ -1609,7 +1596,6 @@ DOMWindow* LocalDOMWindow::open(const String& urlString,
DEFINE_TRACE(LocalDOMWindow) {
visitor->trace(m_document);
- visitor->trace(m_properties);
visitor->trace(m_screen);
visitor->trace(m_history);
visitor->trace(m_locationbar);
« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalDOMWindow.h ('k') | third_party/WebKit/Source/core/frame/Location.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698