Refactoring: Simplify setUp in update_w3c_test_expectations_unittest.py.

Simplify update_w3c_test_expectations_unittest.py.

In this unit test, there were several example dicts set up in the setUp
method; this CL changes it so that literal dicts are used in individual
methods. I think that this would make it easier to read individual
test methods in isolation.

Note, this unit test was originally written by our summer 2016 interns,
who added update_w3c_test_expectations.py (which is responsible for
updating baselines and TestExpectations during the import process).

This CL also simplifies some example dicts/strings.

Review-Url: https://codereview.chromium.org/2629253002
Cr-Commit-Position: refs/heads/master@{#443469}
Committed: https://chromium.googlesource.com/chromium/src/+/290a4d72a0d9671c579a6b3d635ba1cad49bfe50

[qyearsley, 2017-01-12 22:31:47]

Description was changed from

==========
Simplify update_w3c_test_expectations_unittest.py.

In this unit test, there were several example dicts set up in the setUp
method; this CL changes it so that literal dicts are used in individual
methods. The purpose of this is so that it's easier to read individual
test methods in isolation.
==========

to

==========
Simplify update_w3c_test_expectations_unittest.py.

In this unit test, there were several example dicts set up in the setUp
method; this CL changes it so that literal dicts are used in individual
methods. I think that this would make it easier to read individual
test methods in isolation.

Note, this unit test was originally written by our summer 2016 interns, who
added update_w3c_test_expectations.py (which is responsible for updating
baselines and TestExpectations during the import process).
==========

[qyearsley, 2017-01-12 22:31:47]

qyearsley@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[qyearsley, 2017-01-12 22:32:29]

Description was changed from

==========
Simplify update_w3c_test_expectations_unittest.py.

In this unit test, there were several example dicts set up in the setUp
method; this CL changes it so that literal dicts are used in individual
methods. I think that this would make it easier to read individual
test methods in isolation.

Note, this unit test was originally written by our summer 2016 interns, who
added update_w3c_test_expectations.py (which is responsible for updating
baselines and TestExpectations during the import process).
==========

to

==========
Simplify update_w3c_test_expectations_unittest.py.

In this unit test, there were several example dicts set up in the setUp
method; this CL changes it so that literal dicts are used in individual
methods. I think that this would make it easier to read individual
test methods in isolation.

Note, this unit test was originally written by our summer 2016 interns,
who added update_w3c_test_expectations.py (which is responsible for
updating baselines and TestExpectations during the import process).

This CL also simplifies some example dicts/strings.
==========

[jeffcarp, 2017-01-13 01:02:28]

lgtm

https://codereview.chromium.org/2629253002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py
(right):

https://codereview.chromium.org/2629253002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py:285:
'three': {'expected': 'FAIL', 'actual': 'PASS'}
(nit) should there be a trailing comma here? (and below)

[qyearsley, 2017-01-13 01:15:49]

https://codereview.chromium.org/2629253002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py
(right):

https://codereview.chromium.org/2629253002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py:285:
'three': {'expected': 'FAIL', 'actual': 'PASS'}
On 2017/01/13 at 01:02:28, jeffcarp wrote:
> (nit) should there be a trailing comma here? (and below)

Trailing commas are optional (the linter doesn't check this), but I like them
and it's good to be consistent. Now added.

[qyearsley, 2017-01-13 01:16:20]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2017-01-13 01:16:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
jeffcarp@chromium.org
Link to the patchset: https://codereview.chromium.org/2629253002/#ps20001
(title: "Add commas for consistency")

[commit-bot: I haz the power, 2017-01-13 01:17:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 02:20:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484270180141500,
"parent_rev": "b457f0ab9dac0e67cab0b84134999a1c6b0d5e40", "commit_rev":
"290a4d72a0d9671c579a6b3d635ba1cad49bfe50"}

[commit-bot: I haz the power, 2017-01-13 02:21:08]

Description was changed from

==========
Simplify update_w3c_test_expectations_unittest.py.

In this unit test, there were several example dicts set up in the setUp
method; this CL changes it so that literal dicts are used in individual
methods. I think that this would make it easier to read individual
test methods in isolation.

Note, this unit test was originally written by our summer 2016 interns,
who added update_w3c_test_expectations.py (which is responsible for
updating baselines and TestExpectations during the import process).

This CL also simplifies some example dicts/strings.
==========

to

==========
Simplify update_w3c_test_expectations_unittest.py.

In this unit test, there were several example dicts set up in the setUp
method; this CL changes it so that literal dicts are used in individual
methods. I think that this would make it easier to read individual
test methods in isolation.

Note, this unit test was originally written by our summer 2016 interns,
who added update_w3c_test_expectations.py (which is responsible for
updating baselines and TestExpectations during the import process).

This CL also simplifies some example dicts/strings.

Review-Url: https://codereview.chromium.org/2629253002
Cr-Commit-Position: refs/heads/master@{#443469}
Committed:
https://chromium.googlesource.com/chromium/src/+/290a4d72a0d9671c579a6b3d635b...
==========

[commit-bot: I haz the power, 2017-01-13 02:21:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/290a4d72a0d9671c579a6b3d635b...