content: Remove blimp compositing dependencies.

content: Remove blimp compositing dependencies.

This change removes all code for enabling blimp mode in content to run
the compositor with proto serialization and plumbing of these protos
across the IPC boundary.

BUG=677556
Review-Url: https://codereview.chromium.org/2629243002
Cr-Commit-Position: refs/heads/master@{#444924}
Committed: https://chromium.googlesource.com/chromium/src/+/d7178e48283e3c8ffbf8d45049066b65ab2d22dd

[Khushal, 2017-01-12 22:36:55]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 22:37:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 22:44:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 22:44:56]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Khushal, 2017-01-17 23:58:00]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 23:58:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 00:04:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 00:04:33]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Khushal, 2017-01-18 00:07:59]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 00:08:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 01:23:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 01:23:55]

Dry run: This issue passed the CQ dry run.

[Khushal, 2017-01-18 02:03:07]

khushalsagar@chromium.org changed reviewers:
+ jam@chromium.org

[Khushal, 2017-01-18 02:03:42]

khushalsagar@chromium.org changed reviewers:
+ dcheng@chromium.org

[Khushal, 2017-01-18 02:03:43]

+dcheng for IPC review.

[dcheng, 2017-01-18 02:54:01]

ipc rs lgtm

[Khushal, 2017-01-18 21:24:20]

ping to jam@. :)

[Khushal, 2017-01-19 21:14:25]

Description was changed from

==========
content: Remove blimp compositing dependencies.

This change removes all code for enabling blimp mode in content to run
the compositor with proto serialization and plumbing of these protos
across the IPC boundary.

BUG=677556
==========

to

==========
content: Remove blimp compositing dependencies.

This change removes all code for enabling blimp mode in content to run
the compositor with proto serialization and plumbing of these protos
across the IPC boundary.

BUG=677556
==========

[Khushal, 2017-01-19 21:14:26]

khushalsagar@chromium.org changed reviewers:
+ piman@chromium.org

[Khushal, 2017-01-19 21:15:06]

+piman, looks like jam is OOO. Do you mind taking a look at this?

[Khushal, 2017-01-19 22:59:37]

khushalsagar@chromium.org changed reviewers:
+ creis@chromium.org
- piman@chromium.org

[Khushal, 2017-01-19 23:01:00]

Didn't see the block up on piman's calendar, he's OOO till the end of next
month. :P
+cries, mind taking a look at this?

[Khushal, 2017-01-19 23:01:21]

On 2017/01/19 23:01:00, Khushal wrote:
> Didn't see the block up on piman's calendar, he's OOO till the end of next
> month. :P
> +cries, mind taking a look at this?

*creis

[Charlie Reis, 2017-01-19 23:37:33]

Thanks for the cleanup!  LGTM.

https://codereview.chromium.org/2629243002/diff/60001/content/common/view_mes...
File content/common/view_messages.h (left):

https://codereview.chromium.org/2629243002/diff/60001/content/common/view_mes...
content/common/view_messages.h:614: 
nit: Don't remove this blank line.

https://codereview.chromium.org/2629243002/diff/60001/content/renderer/gpu/re...
File content/renderer/gpu/render_widget_compositor.cc (right):

https://codereview.chromium.org/2629243002/diff/60001/content/renderer/gpu/re...
content/renderer/gpu/render_widget_compositor.cc:220:
cc::LayerTreeHostInProcess::InitParams params;
Style nit: Fix indent on this block.

(Might be worth running git cl format on the CL?)

[Khushal, 2017-01-19 23:47:17]

Thanks!

https://codereview.chromium.org/2629243002/diff/60001/content/common/view_mes...
File content/common/view_messages.h (left):

https://codereview.chromium.org/2629243002/diff/60001/content/common/view_mes...
content/common/view_messages.h:614: 
On 2017/01/19 23:37:33, Charlie Reis wrote:
> nit: Don't remove this blank line.

Done.

https://codereview.chromium.org/2629243002/diff/60001/content/renderer/gpu/re...
File content/renderer/gpu/render_widget_compositor.cc (right):

https://codereview.chromium.org/2629243002/diff/60001/content/renderer/gpu/re...
content/renderer/gpu/render_widget_compositor.cc:220:
cc::LayerTreeHostInProcess::InitParams params;
On 2017/01/19 23:37:33, Charlie Reis wrote:
> Style nit: Fix indent on this block.
> 
> (Might be worth running git cl format on the CL?)

Woops. Done.

[Khushal, 2017-01-19 23:47:46]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2017-01-19 23:47:47]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2629243002/#ps80001
(title: "..")

[commit-bot: I haz the power, 2017-01-19 23:48:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 01:31:53]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484869666789910,
"parent_rev": "a3aeda6bc69b867f4a7eac5328420705b830fa21", "commit_rev":
"d7178e48283e3c8ffbf8d45049066b65ab2d22dd"}

[commit-bot: I haz the power, 2017-01-20 01:35:45]

Description was changed from

==========
content: Remove blimp compositing dependencies.

This change removes all code for enabling blimp mode in content to run
the compositor with proto serialization and plumbing of these protos
across the IPC boundary.

BUG=677556
==========

to

==========
content: Remove blimp compositing dependencies.

This change removes all code for enabling blimp mode in content to run
the compositor with proto serialization and plumbing of these protos
across the IPC boundary.

BUG=677556

Review-Url: https://codereview.chromium.org/2629243002
Cr-Commit-Position: refs/heads/master@{#444924}
Committed:
https://chromium.googlesource.com/chromium/src/+/d7178e48283e3c8ffbf8d4504906...
==========

[commit-bot: I haz the power, 2017-01-20 01:35:46]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/d7178e48283e3c8ffbf8d4504906...