Add a country field to TranslateEventProto.

Add a country field to TranslateEventProto.

This field will be useful to log explicitly the country that we get at inference time in the client, which may be different from the one we can infer from GWSLogs data on the server side. A discrepancy in data between inference and training can hurt the performance of translateRanker.

See cl/146667100 for the Google3 side CL.

BUG=653700
Review-Url: https://codereview.chromium.org/2629173002
Cr-Commit-Position: refs/heads/master@{#450049}
Committed: https://chromium.googlesource.com/chromium/src/+/9e98a60b54d634b3e9b34785de505f20fb576e36

[hamelphi, 2017-01-12 17:02:22]

Description was changed from

==========
Add a country field to TranslateEventProto.

BUG=653700
==========

to

==========
Add a country field to TranslateEventProto.

This field will be useful to log explicitly the country that we get at inference
time in the client, which may be different from the one we can infer from
GWSLogs data on the server side. A discrepancy in data between inference and
training can hurt the performance of translateRanker.

Also, even if we end up not filling this field in the client-side, this field is
useful to have on the server side where we can fill it in from GWSLogs metadata.
This way, we can encapsualte in the TEP all the data required for producing a
training example.

BUG=653700
==========

[hamelphi, 2017-01-12 17:02:23]

hamelphi@chromium.org changed reviewers:
+ asvitkine@chromium.org, battre@chromium.org

[hamelphi, 2017-02-06 16:46:07]

Proto change has been submitted on Google3. This is ready for review.

[Alexei Svitkine (slow), 2017-02-06 16:53:58]

lgtm

[hamelphi, 2017-02-06 18:21:57]

hamelphi@chromium.org changed reviewers:
- battre@chromium.org

[hamelphi, 2017-02-06 18:21:57]

Thanks, removing battre@ from reviewers, as he is OOO and already approved the
server side CL.

[hamelphi, 2017-02-06 18:24:18]

The CQ bit was checked by hamelphi@chromium.org

[commit-bot: I haz the power, 2017-02-06 18:24:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 18:33:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 18:33:58]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hamelphi, 2017-02-06 19:10:16]

hamelphi@chromium.org changed reviewers:
+ groby@chromium.org

[hamelphi, 2017-02-06 19:10:17]

+groby@ for review for OWNERS approval of the translate code.

[hamelphi, 2017-02-13 16:52:52]

Description was changed from

==========
Add a country field to TranslateEventProto.

This field will be useful to log explicitly the country that we get at inference
time in the client, which may be different from the one we can infer from
GWSLogs data on the server side. A discrepancy in data between inference and
training can hurt the performance of translateRanker.

Also, even if we end up not filling this field in the client-side, this field is
useful to have on the server side where we can fill it in from GWSLogs metadata.
This way, we can encapsualte in the TEP all the data required for producing a
training example.

BUG=653700
==========

to

==========
Add a country field to TranslateEventProto.

This field will be useful to log explicitly the country that we get at inference
time in the client, which may be different from the one we can infer from
GWSLogs data on the server side. A discrepancy in data between inference and
training can hurt the performance of translateRanker.

See cl/146667100 for the Google3 side CL.

BUG=653700
==========

[groby-ooo-7-16, 2017-02-13 18:48:30]

lgtm

[groby-ooo-7-16, 2017-02-13 18:48:34]

The CQ bit was checked by groby@chromium.org

[commit-bot: I haz the power, 2017-02-13 18:49:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 19:50:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487011714682720,
"parent_rev": "691539d820c280e12e7fcd61d21cdf186788d861", "commit_rev":
"9e98a60b54d634b3e9b34785de505f20fb576e36"}

[commit-bot: I haz the power, 2017-02-13 19:51:31]

Description was changed from

==========
Add a country field to TranslateEventProto.

This field will be useful to log explicitly the country that we get at inference
time in the client, which may be different from the one we can infer from
GWSLogs data on the server side. A discrepancy in data between inference and
training can hurt the performance of translateRanker.

See cl/146667100 for the Google3 side CL.

BUG=653700
==========

to

==========
Add a country field to TranslateEventProto.

This field will be useful to log explicitly the country that we get at inference
time in the client, which may be different from the one we can infer from
GWSLogs data on the server side. A discrepancy in data between inference and
training can hurt the performance of translateRanker.

See cl/146667100 for the Google3 side CL.

BUG=653700

Review-Url: https://codereview.chromium.org/2629173002
Cr-Commit-Position: refs/heads/master@{#450049}
Committed:
https://chromium.googlesource.com/chromium/src/+/9e98a60b54d634b3e9b34785de50...
==========

[commit-bot: I haz the power, 2017-02-13 19:51:37]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9e98a60b54d634b3e9b34785de50...