Issue 2629143002: [runtime] Remove SharedFunctionInfo::is_function which is the inverse of SFI::is_toplevel

Issue 2629143002: [runtime] Remove SharedFunctionInfo::is_function which is the inverse of SFI::is_toplevel (Closed)

Created:
3 years, 11 months ago by Toon Verwaest

Modified:
3 years, 11 months ago

Reviewers:
Igor Sheludko

CC:
v8-reviews_googlegroups.com, Yang

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[runtime] Remove SharedFunctionInfo::is_function which is the inverse of SFI::is_toplevel BUG= Review-Url: https://codereview.chromium.org/2629143002 Cr-Commit-Position: refs/heads/master@{#42275} Committed: https://chromium.googlesource.com/v8/v8/+/75a2fce3a2ad5a9857f1dd203b95b857c7fa12f1

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -22 lines)			Patch
M	src/ast/ast.h	View	1	6 chunks	+4 lines, -8 lines	0 comments	Download
M	src/compiler-dispatcher/compiler-dispatcher.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/debug/debug-evaluate.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/runtime/runtime-internal.cc	View		1 chunk	+2 lines, -6 lines	0 comments	Download

Total messages: 8 (4 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629143002/20001

3 years, 11 months ago (2017-01-12 15:29:33 UTC) #5

commit-bot: I haz the power

3 years, 11 months ago (2017-01-12 16:16:19 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/75a2fce3a2ad5a9857f1dd203b95b857c7f...