Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2629123002: Remove (semi-unmaintained) kernel write code (Closed)

Created:
3 years, 11 months ago by jensj
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove kernel write code. It is not used, we cannot test if it would even produce a valid file (hint: it would not, see closed https://codereview.chromium.org/2621383005/ for a fix though). R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/81821ce9b4d1496b5a360bf0110c5723f8e7e38f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1290 lines) Patch
M runtime/vm/kernel.h View 97 chunks +2 lines, -120 lines 0 comments Download
M runtime/vm/kernel_binary.cc View 86 chunks +0 lines, -1170 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
jensj
3 years, 11 months ago (2017-01-12 12:53:05 UTC) #4
kustermann
LGTM
3 years, 11 months ago (2017-01-12 12:54:10 UTC) #5
jensj
3 years, 11 months ago (2017-01-13 09:35:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
81821ce9b4d1496b5a360bf0110c5723f8e7e38f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698