Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2621383005: Reintroduce binary to load and save dill file. (Closed)

Created:
3 years, 11 months ago by jensj
Modified:
3 years, 11 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reintroduce binary to load and save dill file. The kernel_binary file as code for write as well as for read. Previously we had a binary that could load and save the dill file so we could check that the writing at least produced a valid output (by roundtripping). This reintroduces that binary, as well as fixes the writing to actually allow for roundtripping.

Patch Set 1 #

Patch Set 2 : Removed useless line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -0 lines) Patch
M runtime/bin/BUILD.gn View 1 chunk +68 lines, -0 lines 0 comments Download
M runtime/vm/kernel_binary.cc View 1 chunk +1 line, -0 lines 0 comments Download
A runtime/vm/kernel_main.cc View 1 1 chunk +141 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
jensj
a) Whether we actually still want this or not, I'm not sure (but if we ...
3 years, 11 months ago (2017-01-12 10:04:10 UTC) #2
jensj
3 years, 11 months ago (2017-01-12 11:11:01 UTC) #3
Closing this as consensus seems to be that we should delete the writing code
instead.

Powered by Google App Engine
This is Rietveld 408576698