Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2629113003: DevTools: visualize dependencies using jquery.graphviz.svg (Closed)

Created:
3 years, 11 months ago by chenwilliam
Modified:
3 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: visualize dependencies using jquery.graphviz.svg BUG=679901 Review-Url: https://codereview.chromium.org/2629113003 Cr-Commit-Position: refs/heads/master@{#443699} Committed: https://chromium.googlesource.com/chromium/src/+/561a6916f3f37be95731a7b7331f6feb6415c6b8

Patch Set 1 #

Total comments: 1

Patch Set 2 : node server #

Patch Set 3 : remove d3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -117 lines) Patch
D third_party/WebKit/Source/devtools/scripts/visualize_deps/d3.html View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/visualize_deps/generate_dot.js View 1 1 chunk +0 lines, -56 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/visualize_deps/generate_js.js View 1 1 chunk +0 lines, -33 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/visualize_deps/jquery_svg.html View 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/visualize_deps/run_visualize.js View 1 1 chunk +117 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
chenwilliam
ptal.
3 years, 11 months ago (2017-01-12 23:48:44 UTC) #3
pfeldman
https://codereview.chromium.org/2629113003/diff/1/third_party/WebKit/Source/devtools/scripts/visualize_deps/jquery_svg.html File third_party/WebKit/Source/devtools/scripts/visualize_deps/jquery_svg.html (right): https://codereview.chromium.org/2629113003/diff/1/third_party/WebKit/Source/devtools/scripts/visualize_deps/jquery_svg.html#newcode2 third_party/WebKit/Source/devtools/scripts/visualize_deps/jquery_svg.html:2: * Copyright (c) 2015 Mountainstorm You don't need to ...
3 years, 11 months ago (2017-01-13 00:41:43 UTC) #4
chenwilliam
ptal. The node.js is now the static file server and I removed the d3 files.
3 years, 11 months ago (2017-01-13 19:52:23 UTC) #5
pfeldman
lgtm
3 years, 11 months ago (2017-01-13 20:00:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629113003/40001
3 years, 11 months ago (2017-01-13 21:14:48 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 22:25:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/561a6916f3f37be95731a7b7331f...

Powered by Google App Engine
This is Rietveld 408576698