sdk/lib/_internal/compiler/implementation/mirrors_used.dart - Issue 26291005: dart2js: The name of a library without a library declaration is the empty string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/mirrors_used.dart

Issue 26291005: dart2js: The name of a library without a library declaration is the empty string. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/js_backend/namer.dart ('K') | « sdk/lib/_internal/compiler/implementation/library_loader.dart ('k') | sdk/lib/_internal/compiler/implementation/typechecker.dart » ('j') | sdk/lib/_internal/lib/js_mirrors.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/mirrors_used.dart

diff --git a/sdk/lib/_internal/compiler/implementation/mirrors_used.dart b/sdk/lib/_internal/compiler/implementation/mirrors_used.dart

index aad7d8b67b83f381ac04c413015c95d651ee4d6e..d1c10cf45a1cfe363a6100eeda6e3cb25669cc4c 100644

--- a/sdk/lib/_internal/compiler/implementation/mirrors_used.dart

+++ b/sdk/lib/_internal/compiler/implementation/mirrors_used.dart

@@ -486,7 +486,7 @@ class MirrorUsageBuilder {

String libraryNameCandiate;

for (LibraryElement l in compiler.libraries.values) {

if (l.hasLibraryName()) {

- String libraryName = l.getLibraryOrScriptName();

+ String libraryName = l.getLibraryName();

if (string == libraryName) {

// Found an exact match.

libraryCandiate = l;

@@ -544,7 +544,7 @@ class MirrorUsageBuilder {

compiler.reportHint(

spannable, MessageKind.MIRRORS_CANNOT_RESOLVE_IN_LIBRARY,

{'name': identifiers[0],

- 'library': library.getLibraryOrScriptName()});

+ 'library': library.getLibraryName()});

} else {

compiler.reportHint(

spannable, MessageKind.MIRRORS_CANNOT_FIND_IN_ELEMENT,