sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart - Issue 26291005: dart2js: The name of a library without a library declaration is the empty string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

Issue 26291005: dart2js: The name of a library without a library declaration is the empty string. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/js_backend/namer.dart ('K') | « sdk/lib/_internal/compiler/implementation/js_backend/namer.dart ('k') | sdk/lib/_internal/compiler/implementation/library_loader.dart » ('j') | sdk/lib/_internal/lib/js_mirrors.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

index cea45c9df7c59fa73b4f8a1faeacc8c51d9fe3b5..e040c1ca472387ac7ff011cec6080d47d2bc1d71 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart

@@ -1880,7 +1880,7 @@ mainBuffer.add(r'''

if (buffer != null) {

var metadata = buildMetadataFunction(library);

mainBuffer

- ..write('["${library.getLibraryOrScriptName()}",$_')

+ ..write('["${library.getLibraryName()}",$_')

..write('"${uri}",$_')

..write(metadata == null

? "" : jsAst.prettyPrint(metadata, compiler))

@@ -1898,7 +1898,7 @@ mainBuffer.add(r'''

buffer = buffers[1];

if (buffer != null) {

deferredLibraries

- ..write('["${library.getLibraryOrScriptName()}",$_')

+ ..write('["${library.getLibraryName()}",$_')

..write('"${uri}",$_')

..write('[],$_')

..write(namer.globalObjectFor(library))