Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2629083004: [Media>UI] Follow-up fix for avoiding downloading image twice (Closed)

Created:
3 years, 11 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 11 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media>UI] Follow-up fix for avoiding downloading image twice Previously the cached src for last media image will be reset when the download callback returns a failure (404, image, etc.), thus the image will be fetched another time when the session goes active. This CL removes the reset in this case thus avoiding trying fetching the image another time while already knowing it will fail. BUG=672023 Review-Url: https://codereview.chromium.org/2629083004 Cr-Commit-Position: refs/heads/master@{#443871} Committed: https://chromium.googlesource.com/chromium/src/+/27ecb94bbf93d0324fd74ca1f689e806cae2df51

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -14 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaImageManager.java View 4 chunks +6 lines, -14 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaImageManagerTest.java View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Zhiqiang Zhang (Slow)
PTAL A follow-up fix is per https://bugs.chromium.org/p/chromium/issues/detail?id=672023#c13
3 years, 11 months ago (2017-01-13 14:09:19 UTC) #2
mlamouri (slow - plz ping)
lgtm
3 years, 11 months ago (2017-01-16 11:30:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629083004/1
3 years, 11 months ago (2017-01-16 11:30:53 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 12:05:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/27ecb94bbf93d0324fd74ca1f689...

Powered by Google App Engine
This is Rietveld 408576698