MD Settings: fix crash from strongly bound handler that goes away

MD Settings: fix crash from strongly bound handler that goes away

R=mahmadi@chromium.org
BUG=679993
Review-Url: https://codereview.chromium.org/2629083002
Cr-Commit-Position: refs/heads/master@{#443312}
Committed: https://chromium.googlesource.com/chromium/src/+/c013415abe383dc6bddfa06791c109917b822c4f

[Dan Beam, 2017-01-12 03:02:53]

https://codereview.chromium.org/2629083002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/profile_info_handler.cc (right):

https://codereview.chromium.org/2629083002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/profile_info_handler.cc:128: #if
!defined(OS_CHROMEOS)
yeah yeah yeah, so |weak_ptr_factory_| isn't #if'd on chromeos...

[Dan Beam, 2017-01-12 03:02:58]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 03:03:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 03:12:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 03:12:44]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Moe, 2017-01-12 13:46:35]

On 2017/01/12 03:02:53, Dan Beam wrote:
>
https://codereview.chromium.org/2629083002/diff/1/chrome/browser/ui/webui/set...
> File chrome/browser/ui/webui/settings/profile_info_handler.cc (right):
> 
>
https://codereview.chromium.org/2629083002/diff/1/chrome/browser/ui/webui/set...
> chrome/browser/ui/webui/settings/profile_info_handler.cc:128: #if
> !defined(OS_CHROMEOS)
> yeah yeah yeah, so |weak_ptr_factory_| isn't #if'd on chromeos...

lgtm. Thanks!

[Dan Beam, 2017-01-12 18:33:55]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-01-12 18:34:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 19:05:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484246035880360, "parent_rev":
"bc2f42ed9c2973b356755d4c86b9b521ca66f00c", "commit_rev":
"c013415abe383dc6bddfa06791c109917b822c4f"}

[commit-bot: I haz the power, 2017-01-12 19:06:43]

Description was changed from

==========
MD Settings: fix crash from strongly bound handler that goes away

R=mahmadi@chromium.org
BUG=679993
==========

to

==========
MD Settings: fix crash from strongly bound handler that goes away

R=mahmadi@chromium.org
BUG=679993

Review-Url: https://codereview.chromium.org/2629083002
Cr-Commit-Position: refs/heads/master@{#443312}
Committed:
https://chromium.googlesource.com/chromium/src/+/c013415abe383dc6bddfa06791c1...
==========

[commit-bot: I haz the power, 2017-01-12 19:06:44]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c013415abe383dc6bddfa06791c1...