Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2629033004: Tentative fix for flakiness of fast/input/placeholder-wrongly-placed-if-too-tall.html. (Closed)

Created:
3 years, 11 months ago by tkent
Modified:
3 years, 11 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tentative fix for flakiness of fast/input/placeholder-wrongly-placed-if-too-tall.html. The test quickly finishes usually, but sometimes it doesn't finish. We guess it's possible to call checkInputs() before loading js-test.js. This CL doesn't remove a TestExpectations entry. We'll check if the flakiness is gone later. BUG=675907 Review-Url: https://codereview.chromium.org/2629033004 Cr-Commit-Position: refs/heads/master@{#443475} Committed: https://chromium.googlesource.com/chromium/src/+/5cc4c469882d169f8efb789ff82235252f40f270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/fast/input/placeholder-wrongly-placed-if-too-tall.html View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
tkent
yosin@, would you review this please?
3 years, 11 months ago (2017-01-13 01:33:14 UTC) #3
yosin_UTC9
lgtm Agree. If bot is in heavy load, animation frame start before loading "js-tests.js"
3 years, 11 months ago (2017-01-13 01:44:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629033004/1
3 years, 11 months ago (2017-01-13 01:44:40 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 02:37:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5cc4c469882d169f8efb789ff822...

Powered by Google App Engine
This is Rietveld 408576698